Thread: [noob] i can't even name the problem

program doesn't end loop =P

Code:

#include <stdio.h>

int main(void)
{
	int i,temp;
	
	for (i=1;;i++)
	{
		do {
	
		printf("Enter the temperature for day %d (-300 to end): ",i);
		scanf("%d",&temp);
		
		} while (temp=!-300);
	}
	
	return 0;
}

also, i have to print the hottest and the coolest day. but can't figure how to do it. because day number can be any number. just give me tips. i want to do by myself. =P

well if i put i<=2 then it will stop looping. loop have to stop while temp = -300

ok i removed for loop. it's unnecessary- i see...

Code:

#include <stdio.h>

int main(void)
{
	int i=1;
	int temp;
	
	do {
	
		printf("Enter the temperature for day %d (-300 to end): ",i);
		scanf("%d",&temp);
		i++;
	
	} while (temp!=-300);
	
	return 0;
}

but how can i calculate the hottest and the coolest day?.. i also have to take the average.. day number isn't constant.

well i extended my code.. but miracle c gives a stupid "C:\Program Files\Miracle C\self\fusun.c: line 17: unrecognised types in comparison
'while (temp!=-300) { counter+=1'
aborting compile" error. =P

Code:

#include <stdio.h>

int main(void)
{
	float largest,smallest,average,temp,sum;
	int counter,day,x,y;
	
	smallest=0;
	largest=0;
	sum=0; 
	day=1;
	counter=0;
	
	printf("Enter the temperature for day %d (-300 to end): ",day);  
	scanf("%f",&temp);
	
	while (temp!=-300)
	{
		counter+=1;
		
		if (temp>largest)
		{
			largest=temp;
			x=day;
		}
		
		if (temp<smallest)
		{
			smallest=temp;
			y=day;
		}
	
	++day;
	sum+=temp;
	
	printf("\nEnter the temperature for day %d (-300 to end): ",day);
	scanf("%f",&temp);
	}
	
	printf("The hottest day is %d and the temperature is %f degrees celcius.\n",x,largest);
	printf("The coolest day is %d and the temperature is %f degrees celcius.\n",y,smallest);
	
	average=(float)sum/counter;
	
	printf("The average temperature over %d days is %f degrees celcius\n",day-1,average);
	
	return 0;
}

alright i tweaked a little. one last problem: it counts -300 as temperature. i have to use it to quit.

Code:

#include <stdio.h>

int main(void)
{
	int day=1;
	int cool=0,hot=0,sum=0;
	int counter,temp,x,y;
	float avg;
	
	while (temp!=-300)
	{
		printf("Enter the temperature for day %d (-300 to end): ",day);
		scanf("%d",&temp);
		
		day++;
		++counter;
		
		if (temp>hot)
		{
			hot=temp;
			x=day;
		}
		
		if (temp<cool)
		{
			cool=temp;
			y=day;
		}
		
		sum+=temp;
	}
	
	avg=sum/day;
	
	printf("The hottest day is day %d and the temperature is %d degrees Celcius.\n",x,hot);
	printf("The coolest day is day %d and the temperature is %d degrees Celcius.\n",y,cool);
	printf("The average temperature over %d day(s) is %f degrees Celcius.\n",day-1,avg);
	
	return 0;
}

I think you're logic is a little confused, say what you want to do in english (or your native language), take it one step further into pseudo code.

Example:

Code:

while temp != -300

/* while temp is not equal to -300 */

Which means for the while loop condition to fail, temp has to equal -300

If you want to break out the loop at any given time, you might want to think about testing for an escape character or something. Otherwise, you could always base the while condition on the number of days entered or something.